Add support for instructions and source ranges. #15368
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarlt
force-pushed
the
ethdebug_instructions_and_source_ranges
branch
2 times, most recently
from
82e0668
to
51b69fc
Compare
aarlt
force-pushed
the
ethdebug_instructions_and_source_ranges
branch
2 times, most recently
from
ce130c1
to
feda85c
Compare
aarlt
force-pushed
the
enable_debug_info_ethdebug
branch
from
93749ff
to
0dd51e5
Compare
aarlt
force-pushed
the
ethdebug_instructions_and_source_ranges
branch
from
feda85c
to
fd1bb3a
Compare
aarlt
force-pushed
the
enable_debug_info_ethdebug
branch
from
0dd51e5
to
55503ce
Compare
aarlt
force-pushed
the
enable_debug_info_ethdebug
branch
6 times, most recently
from
32b21f6
to
fe6a4ca
Compare
aarlt
force-pushed
the
enable_debug_info_ethdebug
branch
from
fe6a4ca
to
7917ca3
Compare
cameel
reviewed
Sep 30, 2024
Comment on lines
430
to
431
| util::LazyInit<Json const> ethdebug; | ||
| util::LazyInit<Json const> ethdebugRuntime; |
There was a problem hiding this comment.
Please not. Even storing Yul ASTs was making memory usage go through the roof and giving us a 25% performance hit. And I expect that the whole ethdebug dump will be much bigger than the AST...
See #15451 (comment).
There was a problem hiding this comment.
yeah I saw that and I agree that this might get quite bad with the ethdebug stuff..
aarlt
force-pushed
the
enable_debug_info_ethdebug
branch
6 times, most recently
from
c885a10
to
c4faae4
Compare
aarlt
force-pushed
the
ethdebug_instructions_and_source_ranges
branch
from
fd1bb3a
to
f3205fa
Compare
aarlt
force-pushed
the
enable_debug_info_ethdebug
branch
from
c4faae4
to
c9417ed
Compare
aarlt
force-pushed
the
ethdebug_instructions_and_source_ranges
branch
from
f3205fa
to
3cfe207
Compare
aarlt
force-pushed
the
enable_debug_info_ethdebug
branch
from
c9417ed
to
3432cbe
Compare
aarlt
force-pushed
the
enable_debug_info_ethdebug
branch
4 times, most recently
from
ada3616
to
6b2efa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.